Skip to content

Remove patch that is only needed for clang-tidy to run on test files - #17618

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.02from
vyasr:chore/remove_nanoarrow_patch
Dec 18, 2024
Merged

Remove patch that is only needed for clang-tidy to run on test files#17618
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.02from
vyasr:chore/remove_nanoarrow_patch

Conversation

@vyasr

@vyasr vyasr commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

Description

We stopped running clang-tidy on test files in #17078 so no reason to carry around these patches anymore.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner December 17, 2024 22:10
@vyasr vyasr self-assigned this Dec 17, 2024
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 17, 2024
@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Dec 17, 2024
@vyasr

vyasr commented Dec 17, 2024

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b096182 into NVIDIA:branch-25.02 Dec 18, 2024
@vyasr
vyasr deleted the chore/remove_nanoarrow_patch branch December 18, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants